adding more typehints to DDIM scheduler#456
adding more typehints to DDIM scheduler#456patrickvonplaten merged 7 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
Hey @vishnu-anirudh, this looks great. Can you run (Or I think its just the list order of |
…h/diffusers into type_ddim_diffuser
|
Thank you @natolambert, yes |
This reverts commit a0558b1.
|
Hey @vishnu-anirudh, Super sorry, I just noticed that we actually are making our schedulers framework-specific now (cc @kashif ) so that all arrays should not get a numpy type hint anymore. Very sorry 🙏 @kashif could you maybe link your PR here so that maybe we can improve the type hints there once it's ready? :-) |
|
Apologies! Please continue to check in to PR #534 |
|
Hello @patrickvonplaten That's not a problem. I am happy to fill in the gaps wherever required after this commit is merged. |
* adding more typehints * resolving mypy issues * resolving formatting issue * fixing isort issue Co-authored-by: V Vishnu Anirudh <git.vva@gmail.com> Co-authored-by: V Vishnu Anirudh <vvani@kth.se>
Revert "adding more typehints to DDIM scheduler (huggingface#456)" This reverts commit a0558b1.
5 participants
Adding more type hints to DDIM scheduler to make readability better.